Stop escaping codeFence data-code-raw attribute data #644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up for live markdown preview web PR as there was discovered a bug which prevent parsing when special character was inside codeFence fe.
``` one > two ```
.To fix this issue we shouldn't escape data inside codeFence
data-code-raw
attribute so the input and output of the parser will be the same for thereact-native-live-markdown
libraryFixed Issues
$ Expensify/App#27977
Tests
There are already lots of unit tests present for covering this behaviour. All relevant ones were adjusted to new behaviour
I've checked it on example app of
react-native-live-markdown
library which we are using for text input inside expensify appTo test the behaviour you should use example app of the react-native-live-markdown library. To do so:
/parser
directory and reinstall dependencies (npm install
)npm run build
)``` one > two ```
)QA
There should be no regressions involved as I are only changing the behaviour of html attributed used only in
react-native-live-markdown
library. Any regression are possible only after new version ofreact-native-live-markdown
library is present inside E/App