Refactor ReportScreen to improve chat switching #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deetergp
reviewed
Aug 11, 2021
|
|
||
| /** Whether or not to show the Compose Input */ | ||
| session: PropTypes.shape({ | ||
| shouldShowComposeInput: PropTypes.bool, |
There was a problem hiding this comment.
NAB: Why is this nested in session and not its own prop? Is it because we want to keep track if it in ONXY?
There was a problem hiding this comment.
I can't remember if I did this or if someone else did. But I'm gonna guess it just seemed more convenient than creating a new key to track this.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 12, 2021
|
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This saves about 100ms of time when switching reports and implements a solution to
ReportActionComposebeing slow to render by rendering it only once then re-rendering the Report content instead of the entire view.Fixed Issues (Somewhat related to this closed issue)
#4116
Tests
Android Benchmarks
I tested this PR against Android release builds then compared with the latest
mainreport_switchaverage onmain: 627 msreport_switchaverage on this branch: 528 msQA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
AndroidChatSwitchLatest.mp4