Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/fix!: Dynamic spawn location changes #388

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

SnivyFilms
Copy link

Description

Describe the changes
Adds 5 new dynamic spawn locations:

  • InsideGr18Glass, Spawns in the glass box in GR-18,
  • Inside106Primary, Spawns in SCP-106's Room, near where the keycard and coin spawns.
  • Inside106Secondary, Spawns in SCP-106's Room, on the far side.
  • Inside939Cyro, Spawns in SCP-939's Cryo Room.
  • Inside079Armory, Spawns in SCP-079's Armory.

Removes:

  • InsideNukeArmory, It was broken and the door that was related to it was removed in SCP SL 14.0.0

What is the current behavior? (You can also link to an open issue here)
If using InsideNukeArmory, doesn't do anything.

What is the new behavior? (if this is a feature change)
Allows for 5 new dynamic spawn locations for CustomItems or CustomRoles spawns.
Removes the broken InsideNukeArmory dynamic spawn location.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Enums have been changed. InsideNukeArmory will become something else and users should recheck their configs as a whole due to it, plugins aren't required to be recompiled, but the spawn locations will be incorrect after InsideNukeArmory enum value (I.E. InsideNukeArmory becomes InsideSurfaceNuke in configs automatically)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants