-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PlayGunSound Extensions fix #386
base: dev
Are you sure you want to change the base?
Conversation
Note: Doing things like in PlayGunSound with dummy staying near you works as expected |
After playing sound player get kicked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the used of Server.Host would ne quite problatic in the case of how it's implemented (for example calling the method for gun sound would probably make crash client because of ServerHost having been put to None role
Okay so very strange situation. If we use Fake Sync vars we need delay but if we do like
everything works fine without delays |
so why we don't use this ? |
Cuz someone may use host in some stuff (idk which but it can be used) so if we set it's role for everybody it'll also appear in alive players in spectators list |
oh didn't seen you used CurrentItem |
Description
Describe the changes
Brings back PlayGunSound extension
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Currently volume of sound is very low. Seems like it depends on gun position but idk how to move gun closer to player so it will work (creating instance in Server.Host inv and move it to player doesn't work). I hope that someone has an idea how to do this
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other