-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect common solver functionality in a base class #228
Conversation
…integrated fields.
…Base that must inherit from it.
… params at construction.
… than in destructor.
…m that duplicate base class members.
Once ExCALIBUR-NEPTUNE/NESO-hw-impurity-transport#5 is merged then this can follow quite quickly |
Should run this past Stefan and Sanket before merging because this assumes that there is a single |
Need to create some instructions in the README after NESO 0.1.0. |
Having had another look, I don't think it'll be a problem to adapt the particle system base class to work with multiple |
Instructions for using the base classes in a new solver need to be added (#239), but that may depend on other changes (rearranging submodules etc.) to some extent - I propose we do that in a separate PR. |
…particle-mesh interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built and tests passed.
Description
Creates a base class for solver equation systems from which H3LAPD (DriftReducedSystem) and SimpleSOL (SOLSystem) can inherit. Base class is templated on a nektar equation system (for time-evolving systems, it must derive from UnsteadySystem). Time evolving systems are also templated on a particle system class, which must derive from a new particle system base class.
Type of change
Testing
None added
Checklist:
cmake
clang-format
against my*.hpp
and*.cpp
changescmake-format
against my changes toCMakeLists.txt