Add an event to fill animations for player #870
+118
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microlith57
requested changes
Jan 1, 2025
| /// <br/> <br/> | ||
| /// Mods using this should always add an id to <see cref="List{T}"/> ids whether what the <see cref="string"/> id was given, to avoid certain <see cref="string"/> id missing their animations | ||
| /// </summary> | ||
| public static event GetIdsUsedFillAnimForIdHandler OnGetIdsUsedFillAnimFor; |
There was a problem hiding this comment.
i don't like this name; please make it more descriptive. it should be "OnSomeEvent" where SomeEvent is the description of what event happened
There was a problem hiding this comment.
I'm not good at naming, what do you think of GetIdsToFindAndFillAnimFor
There was a problem hiding this comment.
or FindIdsToFillAnimOfTheirFor
microlith57
changed the title
|
I messed up the merge :despair: it's nearly impossible to resolve online because you "modified" the whole file (probably has to do with line endings) |
maddie480
force-pushed
the
fillAnimForPlayer
branch
from
13ad2a4 to
bf5d29b
Compare
|
I force-pushed to cancel the merge, and just converted Everest.Events to Linux line endings locally, that did it for resolving the "conflict" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.