Introduce minimum, maximum and numeric types #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugZol
requested changes
Feb 3, 2025
README.md
Outdated
| @@ -500,6 +503,12 @@ Returns ValidResult if and only if provided value is an integer. Doesn't transfo | |||
|
|
|||
| I18n keys: `error_key`, `'.integer'`, `'datacaster.errors.integer'`. | |||
|
|
|||
| #### `numeric(error_key = nil)` | |||
|
|
|||
| Returns ValidResult if and only if provided value is a number. Doesn't transform the value. | |||
There was a problem hiding this comment.
"provided value is a number (Ruby's Numeric)"
README.md
Outdated
| @@ -523,6 +532,26 @@ I18n keys: | |||
| * not an integer – `error_key`, `'.integer'`, `'datacaster.errors.integer'` | |||
| * too big – `error_key`, `'.integer32'`, `'datacaster.errors.integer32'` | |||
|
|
|||
| #### `maximum(max, error_key = nil, inclusive: true)` | |||
|
|
|||
| Returns ValidResult if and only if provided value is a number and is less than specified. Doesn't transform the value. | |||
There was a problem hiding this comment.
Returns ValidResult if and only if provided value is a number and is less than `max`. If `inclusive` set to true, provided value should be less than or equal to `max`.
README.md
Outdated
|
|
||
| #### `minimum(min, error_key = nil, inclusive: true)` | ||
|
|
||
| Returns ValidResult if and only if provided value is a number and is greater than specified. Doesn't transform the value. |
There was a problem hiding this comment.
Returns ValidResult if and only if provided value is a number and is greater than `min`. If `inclusive` set to true, provided value should be greater than or equal to `min`.
``
lib/datacaster/version.rb
Outdated
| @@ -1,3 +1,3 @@ | |||
| module Datacaster | |||
| VERSION = "4.1.0" | |||
| VERSION = "4.1.1" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce minimum, maximum and numeric types