-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add design-tokens package #7943
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update: Bringing my branch up to date with latest changes in main
… source and enabled and create a Set of objects representing global and working tokens
Designer/jacqueskeet
Merge pull request #90 from Esri/designer/jacqueskeet
pausing because I want to make sure I fully grok the shape this thing could be in before I finish out this path
Merge pull request #91 from Esri/main
Merge pull request #92 from Esri/designer/jacqueskeet
remove old test files
…/calcite-design-tokens into astump/7180-design-tokens-in-monorepo
this makes the files bigger but it makes SCSS happy
…/calcite-design-tokens into astump/7180-design-tokens-in-monorepo # Conflicts: # packages/calcite-design-tokens/src/component/date-picker.json # packages/calcite-design-tokens/src/component/input-month.json # packages/calcite-design-tokens/src/component/pagination.json # packages/calcite-design-tokens/src/component/rating.json # packages/calcite-design-tokens/src/component/time-picker.json # packages/calcite-design-tokens/support/token-transformer/sd-run.ts
…/calcite-design-tokens into astump/7180-design-tokens-in-monorepo
remove “dark” from tokens set in dark theme
…/calcite-design-tokens into astump/7180-design-tokens-in-monorepo
alisonailea
requested review from
benelan,
jcfranco,
driskull,
geospatialem and
a team
as code owners
October 5, 2023 15:33
…/7180-design-tokens-in-monorepo # Conflicts: # package-lock.json
alisonailea
added
low risk
Issues with low risk for consideration in low risk milestones
p - high
Issue should be addressed in the current milestone, impacts component or core functionality
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
low risk
Issues with low risk for consideration in low risk milestones
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Issues tied to a new feature or request.
p - high
Issue should be addressed in the current milestone, impacts component or core functionality
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Includes the @esri/calcite-design-tokens repo into the calcite monorepo.
Full commit history included
Name changes to calcite-components are necessary because SCSS/CSS output variable names were updated to align with naming patterns
This uses a branch (main-merge-to-calcite-design-system) rather than /main because the build in main is broken.