Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow, flow-item): add component tokens #11365

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

driskull
Copy link
Member

@driskull driskull commented Jan 23, 2025

Related Issue: #7180

Summary

Add flow and flow-item component tokens.

Deprecates the following tokens

  • --calcite-flow-item-footer-padding: [Deprecated] Use --calcite-flow-footer-space instead. Specifies the padding of the component's footer.
  • --calcite-flow-item-header-border-block-end: [Deprecated] Use --calcite-flow-border-color instead. Specifies the component header's block end border.

Adds the following tokens

  • --calcite-flow-corner-radius: Specifies the component's corner radius.
  • --calcite-flow-heading-text-color: Specifies the text color of the component's heading.
  • --calcite-flow-description-text-color: Specifies the text color of the component's description.
  • --calcite-flow-border-color: Specifies the component's border color.
  • --calcite-flow-background-color: Specifies the component's background color.
  • --calcite-flow-header-background-color: Specifies the background color of the component's header.
  • --calcite-flow-footer-background-color: Specifies the background color of the component's footer.
  • --calcite-flow-space: Specifies the padding of the component's "unnamed (default)" slot.
  • --calcite-flow-header-content-space: Specifies the padding of the "header-content" slot.
  • --calcite-flow-footer-space: Specifies the padding of the component's footer.
  • --calcite-action-background-color: Specifies the background color of the component's closable, collapsible, and back calcite-actions. Applies to any slotted calcite-actions.
  • --calcite-action-background-color-hover: Specifies the background color of the component's closable, collapsible, and back calcite-actions when hovered. Applies to any slotted calcite-actions.
  • --calcite-action-background-color-pressed: Specifies the background color of the component's closable, collapsible, and back calcite-actions when pressed. Applies to any slotted calcite-actions.
  • --calcite-action-text-color-hover: Specifies the text and icon color of the component's closable, collapsible, and back calcite-actions when hovered. Applies to any slotted calcite-actions.
  • --calcite-action-text-color-pressed: Specifies the text and icon color of the component's closable, collapsible, and back calcite-actions when pressed. Applies to any slotted calcite-actions.
  • --calcite-popover-border-color: Specifies the border color of the component's internally rendered calcite-popover, which is rendered within a calcite-action menu when slotted calcite-actions are present in the header-actions-end slot. Applies to any slotted calcite-popovers.
  • --calcite-flow-header-action-background-color-hover: Specifies the background color of the component's calcite-action items in the flow item header when hovered.
  • --calcite-flow-header-action-background-color-press: Specifies the background color of the component's calcite-action items in the flow item header when pressed.
  • --calcite-flow-header-action-background-color: Specifies the background color of the component's calcite-action items in the flow item header.
  • --calcite-flow-header-action-indicator-color: Specifies the color of the component's calcite-action items' indicator in the flow item header.
  • --calcite-flow-header-action-text-color-press: Specifies the text color of the component's calcite-action items in the flow item header when pressed.
  • --calcite-flow-header-action-text-color: Specifies the text color of the component's calcite-action items in the flow item header.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jan 23, 2025
@driskull driskull marked this pull request as ready for review January 23, 2025 18:19
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One question about potentially applying the background-color to the Flow container to prevent cases where the BG flashes through against a themed Panel BG.

* @prop --calcite-flow-heading-text-color: Specifies the text color of the component's `heading`.
* @prop --calcite-flow-description-text-color: Specifies the text color of the component's `description`.
* @prop --calcite-flow-border-color: Specifies the component's border color.
* @prop --calcite-flow-background-color: Specifies the component's background color.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: It might be nice to apply this to the Flow container. Currently - if you override a Panel BG, and move between Flows - the animation reveals a different color background (slowed down for dramatic effect) :

Taken from current set up in 3.x with the Panel variables, so may not apply:
https://github.com/user-attachments/assets/df0e93d1-009d-4c08-bc80-e945201eed3d

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants