Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace jest with vitest #11270

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 12, 2025

Related Issue: N/A

Summary

Unifies testing by leveraging existing vitest setup.

Notes

  • test workflows are mostly unchanged (key change involves imports – see https://vitest.dev/api/)
  • jest-axe is still used as it works with our current Puppeteer setup
    • vitest-axe is still in prerelease and has a known issue when integrated with happy-dom
  • updates ESLint, Renovate configs, VS Code launch action and some doc
  • Preact example still uses jest – we can tackle this in a follow-up
  • Moves vitest dep to monorepo root (might need to keep under calcite-components to ensure Lumina doesn't remove matching triple-slash directives
  • Removes obsolete commonTests-scoped ESLint config

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jan 12, 2025
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 12, 2025
@jcfranco jcfranco requested a review from Elijbet January 12, 2025 19:42
* dev:
  build: create a private package for shared eslint configs (#11240)
  build: simplify version placeholder replacement (#11266)
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This LGTM, but I think we should let @alisonailea take a look before merging.

There was a merge conflict with the design token package's eslint config after I installed #11240. I pushed a fix to your branch, hope you don't mind!

Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go!!

@jcfranco jcfranco merged commit 539fb2b into dev Jan 13, 2025
13 of 14 checks passed
@jcfranco jcfranco deleted the jcfranco/move-design-token-tests-to-vitest branch January 13, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants