Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): Don't require filterEnabled for filterPredicate usage #11109

Merged
merged 4 commits into from
Dec 19, 2024
Merged

fix(list): Don't require filterEnabled for filterPredicate usage #11109

merged 4 commits into from
Dec 19, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Dec 19, 2024 •
edited
Loading

Related Issue: #6544

Summary

  • fix to not require filterEnabled to use filterPredicate
  • It was basically the (changes.has("filterPredicate") && this.hasUpdated) that was the culprit.
  • add test

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 19, 2024
@driskull driskull added the no changelog entry Use the commit override to avoid a changelog entry label Dec 19, 2024
@driskull driskull marked this pull request as ready for review December 19, 2024 01:35
benelan
benelan approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 19, 2024
@driskull driskull merged commit dd876e8 into dev Dec 19, 2024
21 checks passed
@driskull driskull deleted the dris0000/filterPredicate-dont-require-filterEnabled branch December 19, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

@eriklharper eriklharper Awaiting requested review from eriklharper

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2025-02-06 - 3.0.0 Feb Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @benelan