Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(block): add component tokens #11014

Merged
merged 11 commits into from
Dec 30, 2024
Merged

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Dec 10, 2024

Related Issue: #7180

Summary

Adds the following subcomponent tokens (CSS props):

  • --calcite-block-border-color
  • --calcite-block-header-background-color
  • --calcite-block-header-background-color-hover
  • --calcite-block-header-text-color
  • --calcite-block-block-text-color
  • --calcite-block-block-text-color-hover

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Dec 10, 2024
@Elijbet Elijbet marked this pull request as ready for review December 10, 2024 22:44
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reassess the block component tokens. Refer to https://github.com/Esri/calcite-design-system/wiki/tokens-component for how to apply tokens.

Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few things. Please make sure to update the PR comment summary as well.

@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 12, 2024
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 13, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Dec 23, 2024
@Elijbet Elijbet requested a review from alisonailea December 26, 2024 19:43
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed Stale Issues or pull requests that have not had recent activity. pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 27, 2024
@Elijbet Elijbet merged commit 3ca4c98 into dev Dec 30, 2024
14 checks passed
@Elijbet Elijbet deleted the elijbet/7180-block-design-tokens branch December 30, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants