fix(action): active styles present with transparent appearance #10988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
reviewed
Dec 4, 2024
There was a problem hiding this comment.
@alisonailea can we get a screenshot test and/or e2e test added to have test coverage for this?
Looks good once there is a test added.
Unrelated but is this a valid selector? Line 122.
Yes. It's valid https://sass-lang.com/playground/#eJwzNNTLrdRNzkksLlao5lJQUNMBEVYZ+WWpRWABBYXk/Jz8IiuFpJzSVCC/lqsWAHeADlM= |
|
Sounds good! |
alisonailea
force-pushed
the
astump/10982-action-active-prop
branch
from
a681da0 to
51b0102
Compare
alisonailea
added
the
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10982
Summary
Resolves issue where transparent styles are not correctly applied when the action[active] state is set.
Adds optional "expectedValue" prop to themed test utility
Adds e2e test coverage