feat(loader): add component tokens #10979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DitwanP
added
the
skip visual snapshots
…nto dit13711/7180-add-tokens-to-loader
…nto dit13711/7180-add-tokens-to-loader
alisonailea
requested changes
Dec 10, 2024
…nto dit13711/7180-add-tokens-to-loader
DitwanP
added
no changelog entry
alisonailea
approved these changes
Dec 10, 2024
…nto dit13711/7180-add-tokens-to-loader
…nto dit13711/7180-add-tokens-to-loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180 #6695
Summary
Add design tokens for loader component along with e2e tests.
New tokens added:
--calcite-loader-progress-color-inline: Specifies the width and height of the component when set to inline.--calcite-loader-text-spacing: Specifies the component's text margin.--calcite-loader-text-weight: Specifies the component's font weight.--calcite-loader-text-color: Specifies the component's text color.--calcite-loader-progress-color: Specifies the component's progress ring color.--calcite-loader-track-color: Specifies the component's track color.Renamed tokens:
--calcite-loader-padding-->--calcite-loader-spacing--calcite-loader-size-inline