-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accordion-item): split header content padding #10865
fix(accordion-item): split header content padding #10865
Conversation
Do we have any conventions for what constitutes a breaking change to the design tokens? Because changes to the json paths could break someone's build script if they are accessing token values for use in their application. |
7b705c7
to
32e76be
Compare
This PR should not have included the space and size token updates which were covered in a separate PR. |
Gotcha was that #10727? Do you think we should add snapshot or test coverage for this fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should add snapshot or test coverage for this fix?
Nevermind, it looks like the existing Custom Theme story picked up this change. Code LGTM, but I'll defer to design for the chromatic approval. cc @ashetland
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue: #10762
Summary
Splits header and content padding rules so the token doesn't apply to header