Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove map widget output and add layers before zooming to them #2199

Open
wants to merge 1 commit into
base: NA/guides_11
Choose a base branch
from
Open

remove map widget output and add layers before zooming to them #2199

wants to merge 1 commit into from

Conversation

jyaistMap
Copy link
Collaborator

  • in a number of places, the map widget output still appeared, so I removed it from those places:
Before After
snow_before image
  • I also changed the order of zoom_to_layer() and add()
    • logically it really confused me to zoom to a layer before it was added to the map. It seems to work - do you think it makes more sense to show adding the layer then zooming to it?

@jyaistMap jyaistMap requested a review from nanaeaubry January 15, 2025 19:55
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jyaistMap jyaistMap mentioned this pull request Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaeaubry nanaeaubry Awaiting requested review from nanaeaubry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jyaistMap