Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for finding a new home sample #2179

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cariashuang0417
Copy link
Contributor

@cariashuang0417 cariashuang0417 commented Dec 6, 2024

This is a PR based off of #2172

The PR:

  • updated all maps to display new map widget symbols and popups
  • added narrations for symbols, popups, some pandas operations, and python api functionalities
  • restructured some sections to make notebook much more smooth
    - move connection to GIS and get item to earlier stage of the notebook
    - some little tweaks on maps in the first section (selling house)

In addition, I am still investigating how to use class_breaks_renderer for sql query on map widget. I will also double check and polish the notebook as needed.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@nanaeaubry nanaeaubry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Mapping code looks good

Copy link

review-notebook-app bot commented Dec 9, 2024

View / edit / reply to this conversation on ReviewNB

neha-sharma-geoai commented on 2024-12-09T07:49:21Z
----------------------------------------------------------------

Notebook looks good. Shouldn't we hide employee IDs from output paths?


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants