New Sample: Overview Map Sample

[mmgaw113]

Sample

The overview map sample is a highly requested sample and was given moderate priority from Adrien.
The sample builds off the overview map created in for the AR Feature Layer sample currently under review. It uses two map components each with a different basemap. The Main ArcGIS Map has a 3D object scene layer where as the overview does not.

Checklist

• PR title follows convention - keyword: Short description of change
• PR targets the correct branch
• Self-review of changes
• There are no warnings related to changes
• A build was made and tested on all relevant platforms
• No unrelated changes have been made to any other code or project files
• No unnecessary includes or namespaces added
• Code follows plugin coding style
• New code and changed code has proper formatting
• No unintentional formatting changes
• Commits have descriptive titles

ArcGIS Maps SDK Version

Maps SDK 1.7 W/ Unity 2022.3 LTS

[Jade-JadeH]

1. Seeing a lighting issue

2. Switching between HDRP and URP doesn't work in the sample viewer

[Jade-JadeH]

See the comments above

[mmgaw113]

Pull the recent changes. I noticed it too and already have it fixed.

[mmgaw113]

Screen.Recording.2024-12-05.at.3.15.31.PM.mov

[Jade-JadeH]

Pull the recent changes. I noticed it too and already have it fixed.

I specifically pulled it after you pushed the changes.

[mmgaw113]

I just tested it and its working, so it sounds like you might have missed the latest commit. See video of it working above ^

[Jade-JadeH]

I like the overall UI design and UX. Works really well.

The two issues I pointed out previously have been resolved after the latest commits.

1. Could you have collider on the top arcgismap or make the second arcgismap invisible, so that when I fly through the map I don't see two maps?

Unity_xhtjrbAu6Y.mp4

2. In doc we have a review process which checks for grammar and punctuation so I took a cursory look here.

[mmgaw113]

Could you have collider on the top arcgismap or make the second arcgismap invisible, so that when I fly through the map I don't see two maps?

Mesh colliders are enabled... Looks like a bug with mesh colliders because you can go through but once you through to the map it won't let you go any further.

[avr757]

I think the UI/UX looks good with the sample! I only have a few small things on the sample viewer menu during testing,

1. It looks like we are only capitalizing the first letter in unity sample list, so let's make those highlighted letter smaller case just to be consistent with other sample names.
   

2. For some reason, I noticed the entire sample list was shifted to the left, can you make a quick change on that?
   

   The scroll view position should be x=375
   

   Should look like this:
   

[avr757]

Ui/UX comments are addressed, looks good now! Thanks

[ZackAllen]

Why do we need to offset the rotation? Why 5/8?

[mmgaw113]

The orientation of the location marker is wrong. Without an offset it will be facing the wrong direction. 225 is the value it is off by. Only way to get rid of the offset is to fix it in a 3D modeling software like Blender

[NaumanIsGISMan]

if you're not planning to expose or change this, it would probably be better as const

[Jade-JadeH]

We've been using camel case so please change naming like the one below

[Jade-JadeH]

Mesh colliders are enabled... Looks like a bug with mesh colliders because you can go through but once you through to the map it won't let you go any further.

Is this issue logged?

[mmgaw113]

We've been using camel case so please change naming like the one below

We don't have a specific naming convention for sub-folders within a sample's folder. But looking at other samples, they follow Pascal Naming Convention, so this is appropriate and I will not be changing it. See attached weather query folder structure.

[Jade-JadeH]

What I was referring to is to remove the space in "UI element" and change it to "UIElement" as space is prone to errors in compiling. Some call it camel case, some call it upper camel case, some call it pascal case

[mmgaw113]

@ZackAllen are we going to start enforcing naming convention for sub folders? Or just Sample Parent Folders?

[NaumanIsGISMan]

private void start

[NaumanIsGISMan]

EOF

[NaumanIsGISMan]

EOF

[NaumanIsGISMan]

if you're not planning to expose or change this, it would probably be better as const

[NaumanIsGISMan]

These chunks are nearly the same and can be refactored. Here's a possible refactor:

private void Update()
    {
        if (cameraLocationComponent == null || locationComponent == null || mapComponent == null)
        {
            return;
        }

        UpdateLocationAndRotation();

        if (rotationToggle.isOn)
        {
            overviewMap.transform.localEulerAngles = new Vector3(0, 0, (float)cameraLocationComponent.Rotation.Heading);
        }
    }

    private void UpdateLocationAndRotation()
    {
        var cameraPosition = cameraLocationComponent.Position;
        var cameraRotation = cameraLocationComponent.Rotation;

        var newPosition = new ArcGISPoint(cameraPosition.X, cameraPosition.Y, locationComponent.Position.Z, mapComponent.OriginPosition.SpatialReference);
        locationComponent.Position = newPosition;

        var newRotation = new ArcGISRotation(cameraRotation.Heading + northOffset, locationComponent.Rotation.Pitch, locationComponent.Rotation.Roll);
        locationComponent.Rotation = newRotation;

        var cameraComponentLocation = cameraComponent.GetComponent<ArcGISLocationComponent>();
        if (cameraComponentLocation != null)
        {
            cameraComponentLocation.Position = new ArcGISPoint(cameraPosition.X, cameraPosition.Y, cameraComponentLocation.Position.Z, mapComponent.OriginPosition.SpatialReference);
        }
    }