Deploy fee contract with alloy #2547
Merged
+252
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a few functions to deploy contracts with alloy and instantiate alloy bindings. Note: the fee contract ethers bindings are still used in Espresso bridge, to migrate the bridge code we need to also create a version of EthSignatureKey that uses alloy types.
sveitser
requested review from
philippecamacho,
ImJeremyHe,
jbearer,
tbro and
imabdulbasit
as code owners
Apparently we need to add some fillers for alloy to build a usable contract transactions. Otherwise fields like from or nonce are missing.
The permissioned stake table was not being deployed because its address was read from the env var. Due to changing transaction counts this then changed the light client contract address. I'm not quite sure why this only caused issues now. - Remove some mentions of the long gone hotshot contract.
|
Demo consistency CI failure is expected because something needed fixing in the process-compose but since docker compose doesn't load env vars by default it's not affected. |
We need to remember to set low polling intervals when we're talking to anvil, otherwise it's set to 7 seconds or something like that. I think alloy has some logic to handle this automatically.
rob-maron
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few functions to deploy contracts with alloy and instantiate alloy bindings. These are generic and should also work for the other contracts. The functions are copies of the functions we had with minimal changes to work with alloy. Added the
_alloysuffix, and types and lifetimes fixed to please compiler.Note: the fee contract ethers bindings are still used in Espresso bridge, to migrate the bridge code we need to also create a version of EthSignatureKey that uses alloy types.
Part of #2535