add timeout to provider::connect() in l1 update loop #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
imabdulbasit
force-pushed
the
ab/l1-connect-timeout
branch
from
92d060c to
028e7c2
Compare
imabdulbasit
changed the title
sveitser
approved these changes
Feb 4, 2025
|
If this works to fix the test for you I think that's great. But please check the logs if it actually does since myself and the CI don't seem to hit this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a timeout to
provider::connect()in the L1 update state loop to prevent hangs due to DNS resolution issues.