[TRACKING] Labrador Release #2519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up some noisy logging (#2459) Don't log warning when a requested object is simply not found (cherry picked from commit 9e69a39) Co-authored-by: Jeb Bearer <[email protected]>
…ersion (#2499) Make migration consistent with deployed version (#2498) At some point, a trailing newline got deleted from a SQL migration, but this file must be byte-for-byte equal with the version which has already been deployed, where the trailing newline is present. (cherry picked from commit e343feb) Co-authored-by: Jeb Bearer <[email protected]>
### This PR: Fixes an issue where `da_membership` was not being passed correctly to `Membership::new` ### This PR does not: ### Key places to review:
…into release-labrador-debug-2
jparr721
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.