Update submit type based on how ballot was submitted

Equal-Vote · Jan 29, 2025 · dcb0e2d · dcb0e2d
1 parent 258e33c
commit dcb0e2d
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/packages/backend/src/Controllers/Ballot/castVoteController.ts b/packages/backend/src/Controllers/Ballot/castVoteController.ts
@@ -31,9 +31,12 @@ type CastVoteEvent = {
     userEmail?:string,
 }
 
+// NOTE: discord isn't implemented yet, but that's the plan for the future
+type BallotSubmitType = 'submitted_via_browser' | 'submitted_via_admin' | 'submitted_via_discord';
+
 const castVoteEventQueue = "castVoteEvent";
 
-async function makeBallotEvent(req: IElectionRequest, targetElection: Election, inputBallot: Ballot, voter_id?: string){
+async function makeBallotEvent(req: IElectionRequest, targetElection: Election, inputBallot: Ballot, submitType: BallotSubmitType, voter_id?: string){
     inputBallot.election_id = targetElection.election_id;
     let roll = null;
 
@@ -74,7 +77,7 @@ async function makeBallotEvent(req: IElectionRequest, targetElection: Election,
     //TODO, ensure the user ID is added to the ballot...
     //should server-authenticate the user id based on auth token
     inputBallot.history.push({
-        action_type:"submit",
+        action_type: submitType,
         actor: roll===null ? '' : roll.voter_id ,
         timestamp:inputBallot.date_submitted,
     });
@@ -118,7 +121,7 @@ async function uploadBallotsController(req: IElectionRequest, res: Response, nex
 
     let events = await Promise.all(
         req.body.ballots.map(({ballot, voter_id} : {ballot: Ballot, voter_id: string}) => 
-            makeBallotEvent(req, targetElection, structuredClone(ballot), voter_id).catch((err) => ({
+            makeBallotEvent(req, targetElection, structuredClone(ballot), 'submitted_via_admin', voter_id).catch((err) => ({
                 error: err,
                 ballot: ballot
             }))
@@ -162,7 +165,7 @@ async function castVoteController(req: IElectionRequest, res: Response, next: Ne
         throw new BadRequest("Election is not open");
     }
 
-    let event = await makeBallotEvent(req, targetElection, req.body.ballot)
+    let event = await makeBallotEvent(req, targetElection, req.body.ballot, 'submitted_via_browser')
 
     event.userEmail = req.body.receiptEmail;