Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nan check #2280

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix nan check #2280

merged 1 commit into from
Jan 23, 2025

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Jan 23, 2025

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/compiler/validation.jl
    • lines 80-81
  • test/applyiter.jl
    • lines 172-172
    • lines 182-182
    • lines 193-193
    • lines 204-204
    • lines 217-217
    • lines 229-230
    • lines 241-242
    • lines 256-256
    • lines 505-505
  • test/mixedapplyiter.jl
    • lines 91-91
    • lines 103-103
    • lines 131-131
    • lines 143-143

Copy link
Contributor

Benchmark Results

main 78aaa16... main/78aaa166f14a8c...
basics/overhead 4.03 ± 0.01 ns 4.34 ± 0.01 ns 0.928
time_to_load 1.1 ± 0.0055 s 1.09 ± 0.011 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@wsmoses wsmoses merged commit 18c95ba into main Jan 23, 2025
26 of 31 checks passed
@wsmoses wsmoses deleted the nancheck branch January 23, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant