Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Prepare for the 1.1.0 release #595

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

edbamolvyavahare
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@wai-wong-edb wai-wong-edb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some change requests. README.md needs to change from 1.0.0 to 1.1.0 too

.goreleaser.yml Outdated
@@ -55,6 +55,6 @@ release:
- glob: 'terraform-registry-manifest.json'
name_template: '{{ .ProjectName }}_{{ .Version }}_manifest.json'
# If you want to manually examine the release before its live, uncomment this line:
draft: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need draft: false rather than commenting it out

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CHANGELOG.md Outdated Show resolved Hide resolved

Import is supported using the following syntax:

{{codefile "shell" "/Users/amol.vyavahare/Documents/projects/terraform-provider-biganimal/examples/resources/biganimal_faraway_replica/import.sh"}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to change

{{ printf "{{codefile \"shell\" %q}}" .ImportFile }}
to {{ codefile "shell" .ImportFile }} and run make docs again

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@edbamolvyavahare edbamolvyavahare force-pushed the prepare-for-1.1.0-release branch from 1cbd46e to e78384b Compare October 21, 2024 13:12
Copy link
Collaborator

@wai-wong-edb wai-wong-edb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wai-wong-edb wai-wong-edb merged commit 1a4740c into main Oct 21, 2024
7 checks passed
@wai-wong-edb wai-wong-edb deleted the prepare-for-1.1.0-release branch October 21, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants