-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Prepare for the 1.1.0 release #595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some change requests. README.md needs to change from 1.0.0 to 1.1.0 too
.goreleaser.yml
Outdated
@@ -55,6 +55,6 @@ release: | |||
- glob: 'terraform-registry-manifest.json' | |||
name_template: '{{ .ProjectName }}_{{ .Version }}_manifest.json' | |||
# If you want to manually examine the release before its live, uncomment this line: | |||
draft: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need draft: false rather than commenting it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/resources/faraway_replica.md
Outdated
|
||
Import is supported using the following syntax: | ||
|
||
{{codefile "shell" "/Users/amol.vyavahare/Documents/projects/terraform-provider-biganimal/examples/resources/biganimal_faraway_replica/import.sh"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to change
{{ printf "{{codefile \"shell\" %q}}" .ImportFile }} |
{{ codefile "shell" .ImportFile }}
and run make docs again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
1cbd46e
to
e78384b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.