fix: Make allowedIpRanges and pgConfig TypeSet #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serdardalgic
added
the
needs_major_bump
serdardalgic
force-pushed
the
type-changes-that-need-major-update
branch
from
1d1f8b6 to
9f2da5c
Compare
serdardalgic
force-pushed
the
type-changes-that-need-major-update
branch
3 times, most recently
from
827689b to
4cc99ba
Compare
serdardalgic
force-pushed
the
type-changes-that-need-major-update
branch
from
4cc99ba to
47d3361
Compare
serdardalgic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are taken out of #123, and they will fix #98.
As explained in this comment, they're breaking changes that demand a major bump.
That's why I would like to keep this PR here and merge it before a major bump (unless we decide to break the API while we still don't have many active users that would be affected from this change)