Edits to Rework bdr.drop_node PGD pr6056 #6116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebgitelman
commented
Sep 30, 2024
| @@ -165,7 +165,7 @@ This function removes the metadata for a given node from the local | |||
| database. The node can be either: | |||
|
|
|||
| - The local node, in which case it removes all the node metadata, including information about remote nodes. | |||
| - A remote node, in which case it only removes metadata for that specific node. | |||
| - A remote node, in which case it removes metadata only for that specific node. | |||
There was a problem hiding this comment.
@djw-m I read this and the previous bullet a few times and I believe this is what you intend? Otherwise it reads like it's only removing metadata. Please verify this is correct.
There was a problem hiding this comment.
It literally only removes metadata and does nothing else.
There was a problem hiding this comment.
Thanks for clarifying. I revised it so there's no ambiguity as to what "only" is referring to.
ebgitelman
commented
Oct 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?