-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for config models #873
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b522535
Add support for config models
barthisrael 18c7e02
Add `barman config-switch` command to the CLI
barthisrael 53c48a0
Adjust `barman diagnose` output in regards to models
barthisrael 152d14e
Rename `.active-model.auto.conf`
barthisrael ef7dabb
Extend unit tests suite due to implementation of config models
barthisrael 64cc57d
Please `flake8`
barthisrael 81b687f
Address suggestions from code review
barthisrael 1c5ac59
Fix servers x models relationship
barthisrael adbd422
PR feedback: rename `get_model_list` as `get_models_list`
barthisrael 75ee860
PR feedback: use blacklist instead of whitelist approach on `ModelCon…
barthisrael File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a
--reset
(or similarly named) option here which would cause Barman to delete the.active-model.audo
file?This could be useful in scenarios where a user removes a model from the configuration while it is still the active model - currently the only way to resolve this case would be to delete the file manually or to
config-swtich
to a different model for the server.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, makes total sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just submitted a commit with these changes.