Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React and React-dom version to RC1 #14

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

eXistenZNL
Copy link
Member

What

Updated React and React DOM deps that depend on RC.1 rather than a specific build.

Why

Freshly cloning this project and and installing the dependencies did no longer work.
I tested this with both Node 18 (NPM 9.8.1) and Node 22 (NPM 10.9.0).

This is the output in such case:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/react
npm error   react@"19.0.0-rc-02c0e824-20241028" from the root project
npm error   peer react@"19.0.0-rc-02c0e824-20241028" from [email protected]
npm error   node_modules/react-dom
npm error     react-dom@"19.0.0-rc-02c0e824-20241028" from the root project
npm error   1 more (styled-jsx)
npm error
npm error Could not resolve dependency:
npm error peer react@">= 0.14.0" from [email protected]
npm error node_modules/markdown-to-jsx
npm error   dev markdown-to-jsx@"^7.7.0" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/react
npm error   peer react@">= 0.14.0" from [email protected]
npm error   node_modules/markdown-to-jsx
npm error     dev markdown-to-jsx@"^7.7.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

@rick-nu
Copy link
Member

rick-nu commented Dec 2, 2024

Nice that this package is available now! 👌

@rick-nu rick-nu merged commit cbdbd20 into production Dec 2, 2024
1 check passed
@rick-nu rick-nu deleted the update-react-deps branch December 2, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants