Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6318 enable faq page #1198

Merged
merged 4 commits into from
Feb 27, 2024
Merged

6318 enable faq page #1198

merged 4 commits into from
Feb 27, 2024

Conversation

PiranavanShanmugavadivelu
Copy link
Contributor

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (5e3ea98) to head (89aa247).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1198   +/-   ##
=======================================
  Coverage   72.61%   72.61%           
=======================================
  Files          88       88           
  Lines       10791    10791           
=======================================
  Hits         7836     7836           
  Misses       2692     2692           
  Partials      263      263           
Flag Coverage Δ
chain 60.75% <ø> (ø)
cosmwasm 98.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jschill jschill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need other FAQ IDs, that are based on the title (FAQ question) rather than an incremental number, since the order of the questions will change and then the numbers are wrong.

Ie "what_are_plastic_credits" rather than "faq_1" etc

Copy link
Contributor

@jschill jschill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@PiranavanShanmugavadivelu PiranavanShanmugavadivelu merged commit 6096696 into main Feb 27, 2024
13 of 14 checks passed
@PiranavanShanmugavadivelu PiranavanShanmugavadivelu deleted the 6318-enable-faq-page branch February 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants