Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #44

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Dev #44

wants to merge 44 commits into from

Conversation

AstroAir
Copy link
Member

No description provided.

AstroAir and others added 23 commits November 2, 2024 14:13
…rmation

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…tom.connection 和 atom.extra 模块的包描述文件,更新 UUID 比较运算符实现,调整 atom.sysinfo 模块的库类型为共享库
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AstroAir! Thanks for this PR.

Copy link

gitguardian bot commented Nov 17, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14531093 Triggered Generic Password 195cc48 modules/lithium.pytools/tools/sevenzip.py View secret
14531093 Triggered Generic Password a22cf41 modules/lithium.pytools/tools/sevenzip.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

AstroAir and others added 10 commits November 18, 2024 20:48
@AstroAir
Copy link
Member Author

This pull request includes significant changes to the CMakeLists.txt file and the addition of new CMake modules. The most important changes include the refactoring of project options, the inclusion of new CMake modules for finding libraries, and the reorganization of subdirectories and include paths.

Refactoring and Reorganization:

  • CMakeLists.txt: Refactored project options by moving them to cmake/options.cmake, and reorganized subdirectories and include paths. Additionally, replaced custom Python package checks with cmake/python_environment.cmake. [1] [2] [3] [4]

New CMake Modules:

Submodule Addition:

  • .gitmodules: Added a new submodule for src/atom from the repository https://github.com/ElementAstro/Atom.

Miscellaneous:

  • README.md: Added embedded WakaTime statistics to the documentation.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
84 Security Hotspots
5.9% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

logger.debug("Starting RANSAC algorithm")
n_data = data.shape[0]
all_idxs = np.arange(n_data)
np.random.default_rng().shuffle(all_idxs)

Check notice

Code scanning / SonarCloud

Results that depend on random number generation should be reproducible Low

Provide a seed for this random generator. See more on SonarQube Cloud
pImpl->recoverFiles();
try {
pImpl->oldJson =
pImpl->loadJSON(jsonFilePath.data(), pImpl->encryptionKey);

Check warning

Code scanning / SonarCloud

std::string_view::data() should not be passed to API expecting C-style strings Medium

Remove this call to data() to properly handle non null-terminated string\_views. See more on SonarQube Cloud
return false;
}
DLOG_F(INFO, "Connecting to Astap Solver...");
if (!atom::io::isFileNameValid(solverPath.data()) || !atom::io::isFileExists(solverPath.data())) {
LOG_F(ERROR, "Failed to execute {}: Invalid Parameters", ATOM_FUNC_NAME);
if (!atom::io::isFileNameValid(solverPath.data()) ||

Check warning

Code scanning / SonarCloud

std::string_view::data() should not be passed to API expecting C-style strings Medium

Remove this call to data() to properly handle non null-terminated string\_views. See more on SonarQube Cloud
if (!atom::io::isFileNameValid(solverPath.data()) || !atom::io::isFileExists(solverPath.data())) {
LOG_F(ERROR, "Failed to execute {}: Invalid Parameters", ATOM_FUNC_NAME);
if (!atom::io::isFileNameValid(solverPath.data()) ||
!atom::io::isFileExists(solverPath.data())) {

Check warning

Code scanning / SonarCloud

std::string_view::data() should not be passed to API expecting C-style strings Medium

Remove this call to data() to properly handle non null-terminated string\_views. See more on SonarQube Cloud
DLOG_F(INFO, "Solving Image {}...", image);
if (!isConnected()) {
LOG_F(ERROR, "Failed to execute {}: Not Connected", __func__);
return false;
}
if (!atom::io::isFileNameValid(image.data()) || !atom::io::isFileExists(image.data())) {
if (!atom::io::isFileNameValid(image.data()) ||

Check warning

Code scanning / SonarCloud

std::string_view::data() should not be passed to API expecting C-style strings Medium

Remove this call to data() to properly handle non null-terminated string\_views. See more on SonarQube Cloud
DLOG_F(INFO, "Solving Image {}...", image);
if (!isConnected()) {
LOG_F(ERROR, "Failed to execute {}: Not Connected", __func__);
return false;
}
if (!atom::io::isFileNameValid(image.data()) || !atom::io::isFileExists(image.data())) {
if (!atom::io::isFileNameValid(image.data()) ||
!atom::io::isFileExists(image.data())) {

Check warning

Code scanning / SonarCloud

std::string_view::data() should not be passed to API expecting C-style strings Medium

Remove this call to data() to properly handle non null-terminated string\_views. See more on SonarQube Cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant