-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #44
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…rmation Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…的异常处理,新增差异比较库及其单元测试
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…tom.connection 和 atom.extra 模块的包描述文件,更新 UUID 比较运算符实现,调整 atom.sysinfo 模块的库类型为共享库
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AstroAir! Thanks for this PR.
… 编码解码函数,删除未使用的函数声明,改进 Platesolve2Solver 和 Platesolve3Solver 类的实现
…imgio.hpp,改进 hist.hpp 和 hfr.hpp 中的函数实现,新增 centroid.hpp 和 fwhm.hpp 文件以支持星体中心计算和高斯拟合,优化 debayer.hpp 文件以支持 FITS 文件读取和去马赛克处理
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14531093 | Triggered | Generic Password | 195cc48 | modules/lithium.pytools/tools/sevenzip.py | View secret |
14531093 | Triggered | Generic Password | a22cf41 | modules/lithium.pytools/tools/sevenzip.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
… 模块的测试文件,验证安装和配置功能,改进异常处理和测试覆盖率
…USB 设备连接和操作,改进 filterwheel 模块的连接和属性监视逻辑
…ase.py 脚本,添加类型注解和丰富的异常处理
This pull request includes significant changes to the Refactoring and Reorganization:
New CMake Modules:
Submodule Addition:
Miscellaneous:
|
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
logger.debug("Starting RANSAC algorithm") | ||
n_data = data.shape[0] | ||
all_idxs = np.arange(n_data) | ||
np.random.default_rng().shuffle(all_idxs) |
Check notice
Code scanning / SonarCloud
Results that depend on random number generation should be reproducible Low
pImpl->recoverFiles(); | ||
try { | ||
pImpl->oldJson = | ||
pImpl->loadJSON(jsonFilePath.data(), pImpl->encryptionKey); |
Check warning
Code scanning / SonarCloud
std::string_view::data() should not be passed to API expecting C-style strings Medium
return false; | ||
} | ||
DLOG_F(INFO, "Connecting to Astap Solver..."); | ||
if (!atom::io::isFileNameValid(solverPath.data()) || !atom::io::isFileExists(solverPath.data())) { | ||
LOG_F(ERROR, "Failed to execute {}: Invalid Parameters", ATOM_FUNC_NAME); | ||
if (!atom::io::isFileNameValid(solverPath.data()) || |
Check warning
Code scanning / SonarCloud
std::string_view::data() should not be passed to API expecting C-style strings Medium
if (!atom::io::isFileNameValid(solverPath.data()) || !atom::io::isFileExists(solverPath.data())) { | ||
LOG_F(ERROR, "Failed to execute {}: Invalid Parameters", ATOM_FUNC_NAME); | ||
if (!atom::io::isFileNameValid(solverPath.data()) || | ||
!atom::io::isFileExists(solverPath.data())) { |
Check warning
Code scanning / SonarCloud
std::string_view::data() should not be passed to API expecting C-style strings Medium
DLOG_F(INFO, "Solving Image {}...", image); | ||
if (!isConnected()) { | ||
LOG_F(ERROR, "Failed to execute {}: Not Connected", __func__); | ||
return false; | ||
} | ||
if (!atom::io::isFileNameValid(image.data()) || !atom::io::isFileExists(image.data())) { | ||
if (!atom::io::isFileNameValid(image.data()) || |
Check warning
Code scanning / SonarCloud
std::string_view::data() should not be passed to API expecting C-style strings Medium
DLOG_F(INFO, "Solving Image {}...", image); | ||
if (!isConnected()) { | ||
LOG_F(ERROR, "Failed to execute {}: Not Connected", __func__); | ||
return false; | ||
} | ||
if (!atom::io::isFileNameValid(image.data()) || !atom::io::isFileExists(image.data())) { | ||
if (!atom::io::isFileNameValid(image.data()) || | ||
!atom::io::isFileExists(image.data())) { |
Check warning
Code scanning / SonarCloud
std::string_view::data() should not be passed to API expecting C-style strings Medium
No description provided.