Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

CI fixes #4969

Merged
merged 2 commits into from
Jul 2, 2023
Merged

CI fixes #4969

merged 2 commits into from
Jul 2, 2023

Conversation

kodebach
Copy link
Member

Contains some fixes for the CI (extracted from #4941), may need to be applied after #4967

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

@kodebach kodebach mentioned this pull request Jun 13, 2023
19 tasks
Copy link
Collaborator

@flo91 flo91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you for getting the macOS builds running again!
Please just add a short description of your changes to the release notes.

@markus2330 markus2330 merged commit cba1dd2 into ElektraInitiative:master Jul 2, 2023
@markus2330
Copy link
Contributor

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants