This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 123
Move headers Part 2 #4940
Merged
kodebach
merged 25 commits into
ElektraInitiative:new-repo-layout
from
kodebach:move-headers-2
Jun 2, 2023
Merged
Move headers Part 2 #4940
kodebach
merged 25 commits into
ElektraInitiative:new-repo-layout
from
kodebach:move-headers-2
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Closed
refactoring done manually to check usages
…eaders refactoring done manually to check uses
libelektra-plugin consists of two separate parts and there should not be a single header to include all of it
kodebach
requested review from
lawli3t,
atmaxinger,
hannes99,
flo91 and
lukashartl
June 1, 2023 13:19
@lawli3t @atmaxinger @hannes99 @flo91 @lukashartl If you review, please read the PR description it explains what's happening in this PR and which files have interesting changes. |
jenkins build libelektra please |
atmaxinger
reviewed
Jun 1, 2023
kodebach
commented
Jun 1, 2023
kodebach
commented
Jun 2, 2023
hannes99
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and matches what was decided in the decision.
jenkins build libelektra please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happens in this PR?
Continuing from #4920, this PR includes further progress on the decisions mentioned in #4920. The goal for this PR is to finish all the header changes, i.e.
src/include
should (basically) have it's new contents completed with this PR.old_helper.h
header into more modular unitsold_helper.h
kdbprivate.h
into more modular units. I did this manually, because I wanted to verify wherekdbprivate.h
is used and why. Partly to ensure there isn't some place that shouldn't use it and partly to inform howkdbprivate.h
should be split up.Hints for reviewers
As with #4920 this PR has a large number of changed files. Most of them once again are only updated
#include
s.src/include/**
split up, moved, rearranged headers according to decisions (the thing that causes all the other changes)src/libs/elektra/CMakeLists.txt
CMake update, not sure if it's needed here, may have slipped into the wrong commit and may only required by Move headers Part 3 #4941, but doesn't break anythingsrc/libs/elektra/backends.h
new header extracted fromkdbprivate.h
src/libs/elektra/hooks.h
new header extracted fromkdbprivate.h
src/libs/elektra/internal.c
movedelektraMemcpy
andelektraMemmove
tokeyset.c
src/libs/elektra/keyset.c
adds a newDEFAULT_KEYSET_SIZE
because the oldKEYSET_SIZE
is no longer in a header AND movedelektraMemcpy
andelektraMemmove
frominternal.c
src/libs/elektra/keytest.c
removal ofkeyIs*
functions which are nowstatic inline
aliasessrc/libs/elektra/symbols.map
now exportselektraReadNamespace
as private (no idea how it worked before)src/libs/highlevel/elektra.h
new header extracted fromkdbprivate.h
src/plugins/xmltool/xmltool.h
removal of unnecessary redeclaration ofelektraStrLen
src/tools/kdb/gen/templates/collect.sh
adds amkdir -p
(no idea what it is needed now)tests/ctest/test_keyset_cow.c
adds a newDEFAULT_KEYSET_SIZE
because the oldKEYSET_SIZE
is no longer in a headerAll other changed files are only changes in
#include
s.Those are the main changes of this PR, below are some extra fixes to please the CI:
doc/man/**
not sure why those changes were needed, but the CI complainedscripts/docker/openwrt/sdk/Dockerfile
update OpenWrt image (should happen on master at some point too)tests/linkchecker.whitelist
add https://opensesame.libelektra.org and https://pull.libelektra.org because of certificate issuesBasics
(added as entry in
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add them to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels