Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

doc: Improve readability of section in High-Level API tutorial #3717

Merged
merged 7 commits into from
Mar 25, 2021

Conversation

qwepoizt
Copy link
Contributor

This is just a minor change to improve readability. After having read through all items of the PR guidelines, I believe none of them applies.

@@ -37,7 +37,7 @@ default = 1.1
```

In Elektra a specification is defined through the metadata of keys in the `spec` namespace. The specification above contains metadata for
three keys the parent key (`@`), `@/mydouble` and `@/myfloatarray/#`. The `#` at the end of `myfloatarray/#` indicates that it is an array.
three keys: 1. the parent key (`@`), 2. `@/mydouble` and 3. `@/myfloatarray/#`. The `#` at the end of `myfloatarray/#` indicates that it is an array.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can even make a proper markdown enumeration?

Please do not forget to add release notes and to make the build server happy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, I converted it into an enum and added release notes!

@markus2330
Copy link
Contributor

Thank you very much for creating the PR!

I believe none of them applies.

Adding something to the release notes always applies because every contribution needs to be honored properly.

@qwepoizt
Copy link
Contributor Author

@markus2330 1 check failed because Cirrus CI reports a broken link (http://www.complang.tuwien.ac.at/raab/akademy.pdf) in doc/news/2018-08-18_0.8.24.md.

Without www the link does not timeout but sends a 404: http://complang.tuwien.ac.at/raab/akademy.pdf

The broken link seems to be unrelated to my changes, I'm not sure how to proceed?

@kodebach
Copy link
Member

Since there is now a merge conflict, you should rebase the PR branch onto master. You can ignore the broken link. We can merge the PR, if everything else works.

Maybe we can fix the link (it is a tuwien.ac.at link after all), but if not we can also add the link to the whitelist.

@mpranj
Copy link
Member

mpranj commented Mar 23, 2021

I suggest ignoring the broken link for now. As announced in #160 our build infrastructure is down. The broken link is affected by the same planned outage which should be resolved today. I would advise against merging during this period.

The merge conflict will need to be resolved by rebasing on current master as @kodebach already said. Otherwise it looks good to me. 👍

@markus2330
Copy link
Contributor

Yes, please add www, this was a recent change in the complang infrastructure. complang.tuwien.ac.at does not redirect to www.complang.tuwien.ac.at anymore.

@qwepoizt
Copy link
Contributor Author

Thank you all for the input, I will attend to it in the coming days.

@qwepoizt
Copy link
Contributor Author

qwepoizt commented Mar 24, 2021

I rebased my branch patch-1 from upstream master and all checks have passed. Please, feel free to merge this PR!

@mpranj mpranj merged commit 8416c9c into ElektraInitiative:master Mar 25, 2021
@mpranj
Copy link
Member

mpranj commented Mar 25, 2021

Thank you so much for the docu improvements!

(The last build error is a known sporadic error #3679)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants