Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to DEVELOPING.md #457

Merged

Conversation

JesusSilvaUtrera
Copy link
Contributor

@JesusSilvaUtrera JesusSilvaUtrera commented Jan 9, 2025

Proposed changes

This PR just changes a broken link on the docs that was pointing to a GETTING_STARTED.md file that doesn't exist anymore. The Table of Content of the file was updated automatically when saving.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Anything worth mentioning to the reviewers.

@JesusSilvaUtrera JesusSilvaUtrera force-pushed the jsilva/fix_developing_md_link branch from 3e1bd43 to 7fde54a Compare January 9, 2025 07:36
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@glpuga
Copy link
Collaborator

glpuga commented Jan 9, 2025

Remember to sign your commit with DCO

@JesusSilvaUtrera
Copy link
Contributor Author

Remember to sign your commit with DCO

@glpuga I forgot at first, but I rebased the branch adding the DCO, it should be alright because the checks are passing.

@glpuga glpuga merged commit f035e0f into Ekumen-OS:main Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants