Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to DEVELOPING.md #456

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Minor fix to DEVELOPING.md #456

merged 1 commit into from
Jan 8, 2025

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Jan 8, 2025

Proposed changes

Add missing step in DEVELOPING.md

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Anything worth mentioning to the reviewers.

@glpuga glpuga requested a review from nahueespinosa January 8, 2025 13:03
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga glpuga force-pushed the glpuga/minor_doc_fix branch from 686c625 to 1a29684 Compare January 8, 2025 17:24
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glpuga glpuga merged commit fef02e1 into main Jan 8, 2025
10 checks passed
@glpuga glpuga deleted the glpuga/minor_doc_fix branch January 8, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants