Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable weekly CI jobs in forks #455

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Disable weekly CI jobs in forks #455

merged 2 commits into from
Dec 20, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Dec 20, 2024

Proposed changes

It has been recently brought to my attention that our weekly CI jobs are getting run in fork repositories. Users may inadvertently end up in this scenario if they enable GHA workflows on their forks, see https://github.com/orgs/community/discussions/26704.

While I do think it makes sense for plain CI jobs to be available to forks if the owners chooses to, weekly CI jobs seem like a waste of compute. This patch ensures those jobs only run for this repository.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic hidmic self-assigned this Dec 20, 2024
@hidmic
Copy link
Collaborator Author

hidmic commented Dec 20, 2024

FYI @pvela2017

@hidmic
Copy link
Collaborator Author

hidmic commented Dec 20, 2024

Got another spurious codecov error. Moving forward.

@hidmic hidmic merged commit c158675 into main Dec 20, 2024
13 of 14 checks passed
@hidmic hidmic deleted the hidmic/no-weekly-ci-in-forks branch December 20, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants