Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ROS 2 Iron support #454

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Drop ROS 2 Iron support #454

merged 2 commits into from
Dec 20, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Dec 20, 2024

Proposed changes

ROS 2 Iron Irwini reached EOL as of late November 2024 and was officially phased out a bit over a week ago https://discourse.ros.org/t/iron-irwini-is-end-of-life/41031. As a consequence, plain rosdep resolve started failing in CI, see #452.

We have no reason to continue supporting ROS 2 Iron, thus this patch drops support for it entirely.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic hidmic self-assigned this Dec 20, 2024
@glpuga
Copy link
Collaborator

glpuga commented Dec 20, 2024

LGTM, but notice there are three more mentions of iron:

  • Two of them in package.xml within beluga_tools
  • One in DEVELOPING.md

Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic hidmic merged commit b2748e4 into main Dec 20, 2024
18 checks passed
@hidmic hidmic deleted the hidmic/iron-eol branch December 20, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants