-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ndt map visualization #453
base: main
Are you sure you want to change the base?
Ndt map visualization #453
Conversation
c766cc5
to
fb2ae87
Compare
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
ec0a0e8
to
d383820
Compare
@Fernando-Sanz Linters are failing, check https://github.com/Ekumen-OS/beluga/blob/main/CONTRIBUTING.md#how-do-i-submit-a-good-code-contribution to install pre-commit. |
Signed-off-by: Fernando <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite solid!
Could you upload a video or image of how the map is looking?
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass
return true; | ||
} | ||
|
||
inline void use_cell_size(const auto& position, const auto& size, auto& marker){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fernando-Sanz I sense this needs some formatting, are we using pre-commit
hooks?
inline void use_cell_size(const auto& position, const auto& size, auto& marker){ | |
inline void use_cell_size(const auto& position, const auto& size, auto& marker) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes(?). Now I'm not sure, I installed it and it was working with previous commits. I'm checking it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fernando-Sanz run pre-commit run --all
.
It may take some time, but it will fix all formatting errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter are happy now though https://github.com/Ekumen-OS/beluga/actions/runs/12319843458/job/34482145756?pr=453.
So I guess this isn't needed anymore
Indeed, linters are not happy. |
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Signed-off-by: Fernando <[email protected]>
Proposed changes
NDT map visualization publisher. It uses ellipsoids to represent obstacles placed using the mean and the covariance matrix of each cell.
Type of change
Checklist