Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ndt map visualization #453

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Fernando-Sanz
Copy link

@Fernando-Sanz Fernando-Sanz commented Dec 3, 2024

Proposed changes

NDT map visualization publisher. It uses ellipsoids to represent obstacles placed using the mean and the covariance matrix of each cell.

ndt_map_visualization_enlarged

Obstacle representation made with green ellipsoids (scale factor is used).

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

beluga_amcl/include/beluga_amcl/ndt_amcl_node_3d.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
@ivanpauno
Copy link
Collaborator

@Fernando-Sanz Linters are failing, check https://github.com/Ekumen-OS/beluga/blob/main/CONTRIBUTING.md#how-do-i-submit-a-good-code-contribution to install pre-commit.
After those steps, linters will run automatically each time you run git commit.
Run pre-commit run -a to fix your previous commits.

Copy link
Collaborator

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite solid!

Could you upload a video or image of how the map is looking?

beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_amcl/src/ndt_amcl_node_3d.cpp Outdated Show resolved Hide resolved
beluga_amcl/include/beluga_amcl/ndt_amcl_node_3d.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass

beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
return true;
}

inline void use_cell_size(const auto& position, const auto& size, auto& marker){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fernando-Sanz I sense this needs some formatting, are we using pre-commit hooks?

Suggested change
inline void use_cell_size(const auto& position, const auto& size, auto& marker){
inline void use_cell_size(const auto& position, const auto& size, auto& marker) {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes(?). Now I'm not sure, I installed it and it was working with previous commits. I'm checking it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fernando-Sanz run pre-commit run --all.
It may take some time, but it will fix all formatting errors.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter are happy now though https://github.com/Ekumen-OS/beluga/actions/runs/12319843458/job/34482145756?pr=453.

So I guess this isn't needed anymore

beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
beluga_ros/include/beluga_ros/ndt_ellipsoid.hpp Outdated Show resolved Hide resolved
@hidmic
Copy link
Collaborator

hidmic commented Dec 13, 2024

Indeed, linters are not happy.

Signed-off-by: Fernando <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants