Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor estimation library #445

Merged
merged 10 commits into from
Oct 15, 2024
Merged

Refactor estimation library #445

merged 10 commits into from
Oct 15, 2024

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Oct 14, 2024 •
edited
Loading

Proposed changes

Related to #385.

As the title says, refactors the estimation library to reduce compile times, improve consistency, and make it easier to extend.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! beluga::calculate_covariance is beluga::covariance and the algorithms are niebloids now.

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

There is room for improvement around this design (i.e. optional return types, more overloads).

@nahueespinosa nahueespinosa self-assigned this Oct 14, 2024
@nahueespinosa nahueespinosa force-pushed the nahuel/refactor-estimation-library branch 4 times, most recently from 858aeeb to 6958a99 Compare October 14, 2024 17:26
@nahueespinosa
Refactor estimation library
046e4d6 
Signed-off-by: Nahuel Espinosa <[email protected]>
@nahueespinosa nahueespinosa force-pushed the nahuel/refactor-estimation-library branch from 6958a99 to 046e4d6 Compare October 14, 2024 18:07
glpuga
glpuga reviewed Oct 14, 2024
View reviewed changes
beluga/test/beluga/algorithm/test_cluster_based_estimation.cpp Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
@nahueespinosa nahueespinosa requested a review from glpuga October 15, 2024 12:03
hidmic
hidmic reviewed Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee

beluga/include/beluga/algorithm/estimation.hpp Show resolved Hide resolved
beluga/test/beluga/algorithm/test_cluster_based_estimation.cpp Show resolved Hide resolved
@nahueespinosa nahueespinosa requested a review from hidmic October 15, 2024 15:59
hidmic
hidmic approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI and @glpuga's approval.

@glpuga
Copy link
Collaborator

glpuga commented Oct 15, 2024

LGTM

@nahueespinosa nahueespinosa merged commit 0df4da0 into main Oct 15, 2024
11 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/refactor-estimation-library branch October 15, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpuga glpuga glpuga approved these changes

@hidmic hidmic hidmic approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nahueespinosa @glpuga @hidmic