Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Beluga documentation style #436

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix Beluga documentation style #436

merged 1 commit into from
Sep 30, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Sep 30, 2024

Proposed changes

actions/upload-artifact 4.4.0 changes getting backported wrecked our documentation, as it silently stopped uploading hidden files by default πŸ€¦β€β™‚οΈ. This patch amends this.

Type of change

  • πŸ› Bugfix (change which fixes an issue)
  • πŸš€ Feature (change which adds functionality)
  • πŸ“š Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

.nojekyll file is getting dropped by default since actions/upload-artifact 4.4.0

Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic hidmic requested a review from glpuga September 30, 2024 02:16
@hidmic hidmic self-assigned this Sep 30, 2024
@hidmic
Copy link
Collaborator Author

hidmic commented Sep 30, 2024

Merging despite Rolling issues. I will fix those in a follow-up PR.

@hidmic hidmic merged commit cfd6af2 into main Sep 30, 2024
15 of 16 checks passed
@hidmic hidmic deleted the hidmic/fix-docs-style branch September 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants