Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to get docker to build in arm64 #411

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Jul 8, 2024

Proposed changes

Minor fixes to the docker image to fix #382

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Tested building on Raspberry 4B and Raspberry 5.

@glpuga glpuga force-pushed the glpuga/fixes_arm_docker branch 2 times, most recently from e0263fd to cd91bea Compare July 8, 2024 21:20
@glpuga glpuga requested a review from nahueespinosa July 8, 2024 21:21
@glpuga glpuga force-pushed the glpuga/fixes_arm_docker branch from cd91bea to 4840532 Compare July 8, 2024 21:22
@glpuga glpuga marked this pull request as ready for review July 8, 2024 21:22
@glpuga glpuga self-assigned this Jul 8, 2024
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glpuga glpuga merged commit 0e12b30 into main Jul 9, 2024
15 checks passed
@glpuga glpuga deleted the glpuga/fixes_arm_docker branch July 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development containers should build in AARCH64
2 participants