feat: added copy feature #175
Conversation
|
@Bashamega you requested a review but there are no changes since my last review - did you forget to push? note: please don't mark inline discussions as resolved, as it makes it more difficult to review |
I am very sorry. I have forgot to push the changes. LOL! |
|
Hello @eddiejaoude I have updated the form to use the Input component and made the input component more customizable |
| aria-hidden="true" | ||
| className="h-5 w-5 text-gray-400" | ||
| className={`h-5 w-5 ${copy ? "text-green-400 " : "text-gray-500 "} `} |
There was a problem hiding this comment.
Best to be consistent and use classNames function here to concatenate class strings
Co-authored-by: Eddie Jaoude <[email protected]>
Co-authored-by: Eddie Jaoude <[email protected]>
|
I have fixed the problems :) |
Co-authored-by: Eddie Jaoude <[email protected]>
| @@ -3,11 +3,14 @@ | |||
| import { | |||
| DocumentDuplicateIcon, | |||
| CheckBadgeIcon, | |||
There was a problem hiding this comment.
I think CheckBadgeIcon is no longer used.
Don't worry about fixing it, I will merge to a temporary branch and fix now, so we can get this feature merged
* feat: copy badge feature (#175) * feat: added copy feature * Switched to asyc * Removed the console log * Format fix * Updated input * format * Uses classnames * Update src/components/forms/Input.js * Update src/app/account/repo/checks/[id]/form.js Co-authored-by: Eddie Jaoude <[email protected]> * Update src/app/account/repo/checks/[id]/form.js Co-authored-by: Eddie Jaoude <[email protected]> * patch: class names * patch: format * Update src/app/account/repo/checks/[id]/form.js Co-authored-by: Eddie Jaoude <[email protected]> * Update src/app/account/repo/checks/[id]/form.js --------- Co-authored-by: Eddie Jaoude <[email protected]> * fix: simplified copy * fix: badge form label * fix: revert input component --------- Co-authored-by: Adam Basha <[email protected]>
Fixes Issue
closes #173
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers