-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/437 document text search #197
Conversation
router.get('/health/etlDomainValues', async function (req, res) { | ||
await checkDomainValuesHealth(req, res); | ||
}); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
a file system access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome and works well!
I left some small suggestions/comments below. I think we need to add some cypress tests around the document search. I'm ok with the tests being a separate PR/ticket.
I just started looking at the changes and noticed that the querying of the original profiles doesn't work any more. The filters aren't filtering anything and the download only has the |
It looks like the issue is just with the actions profile. |
I made some changes to the client-side |
The |
Co-authored-by: Caleb Schwind <[email protected]>
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes.
Related Issues:
Main Changes:
api-public
file with the new profile endpoints.Steps To Test:
TODO:
PreviewModal
component.