Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/350 switch to vite #195

Merged
merged 10 commits into from
Oct 11, 2024
Merged

Conversation

cschwinderg
Copy link
Collaborator

Related Issues:

Main Changes:

  • Switched from create-react-app to vite.
  • Fixed issue of 404.html and 500.html pages not loading epa-template-files resources.
  • Updated the db ssl logic to work of an environment variable instead of NODE_ENV to make it easier to connect to dev/stage/prod databases from local env.
  • Added server side code coverage.
    • Note: I deleted the api-request.cy.ts tests, because I moved these to the server side tests. When these tests were in cypress they didn't really impact coverage much.
  • Added more tests to get code coverage above 80%.

Steps To Test:

  1. Add DB_SSL=false to the etl/.env.local file
  2. Run the etl locally and verify it works
  3. Run npm run setup from app folder
  4. Add DB_SSL=true to the app/server/.env.local file
  5. Update other variables to point your local environment to the dev database
  6. Open an ssh tunnel to the dev database
  7. Run npm run dev to start the app
  8. Manually test various features
  9. Run npm run coverage
  10. Verify all tests pass
  11. Verify coverage results are above 80% and include server side code

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)
3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@maxdiebold-erg maxdiebold-erg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, and that coverage looks fantastic!

@maxdiebold-erg maxdiebold-erg merged commit dd114d2 into develop Oct 11, 2024
3 of 4 checks passed
@maxdiebold-erg maxdiebold-erg deleted the feature/350_switch-to-vite branch October 11, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants