Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimal Checkstyle configuration #704

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Add minimal Checkstyle configuration #704

merged 5 commits into from
Jan 6, 2025

Conversation

xpple
Copy link
Collaborator

@xpple xpple commented Jan 2, 2025 •
edited
Loading

This PR adds a minimal Checkstyle based on the code style guidelines.

@xpple xpple requested a review from Earthcomputer January 3, 2025 14:23
@xpple xpple added the enhancement New feature or request label Jan 3, 2025
Earthcomputer
Earthcomputer reviewed Jan 4, 2025
View reviewed changes
checkstyle.xml Outdated Show resolved Hide resolved
@xpple xpple requested a review from Earthcomputer January 6, 2025 17:20
Earthcomputer
Earthcomputer approved these changes Jan 6, 2025
View reviewed changes
Copy link
Owner

@Earthcomputer Earthcomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still don't like checkstyle but whatever it's better to catch some of the more obvious things in PRs before they get to us.

@Earthcomputer Earthcomputer merged commit 00a34cc into Earthcomputer:fabric Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Earthcomputer Earthcomputer Earthcomputer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xpple @Earthcomputer