Add autoprefix command #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xpple
previously requested changes
Jun 23, 2024
src/main/java/net/earthcomputer/clientcommands/ClientCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
| import static net.fabricmc.fabric.api.client.command.v2.ClientCommandManager.literal; | ||
|
|
||
| public class AutoPrefixCommand { | ||
| private static String currentPrefix = null; |
There was a problem hiding this comment.
I feel like this entire command can be a config instead, but I will continue reviewing the command anyway.
There was a problem hiding this comment.
should it be a config? Should this be persistent?
There was a problem hiding this comment.
Temporary configs exist. Although you would lose the autocompletion for players, unless you resort to a hack. I'll let @Earthcomputer decide.
There was a problem hiding this comment.
ah, i understand, you meant making this a config setting qwq cries
There was a problem hiding this comment.
Yes please move it to a config
There was a problem hiding this comment.
Done, haven't tested it tho
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
Earthcomputer
requested changes
Jun 23, 2024
src/main/java/net/earthcomputer/clientcommands/ClientCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
RealRTTV
reviewed
Jun 23, 2024
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
|
Merge when? 🥺 |
|
Well there is an open question, so not yet. |
Earthcomputer
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command lets you autoprefix in all your messages a text, it can be a command or a simple text.
It's intended use is for
/msg <user>or/tmsgbut it's a flexible addition to the mod :3