Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert: replace .txt extension filter with empty Query filter #35

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

svenrdz
Copy link
Collaborator

@svenrdz svenrdz commented Feb 1, 2024

Resolves #34

The .txt extension filter allowed esgpull convert to be used with a very coarse path, such as **/*.

To keep this feature, convert now compares each generated Query with an "empty" Query that is produced according to default_options set in the config.
Any file that produces that same empty Query is then reject, since we assume this fike was NOT a valid synda selection file.

Changes

  • Remove the .txt extension filter
  • Reject any file producing a converted Query that matches an "empty" Query

@svenrdz svenrdz merged commit e54c4cb into main Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synda selection file conversion fails if there is no ".txt" extension
1 participant