Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update retrieval and writing of dststatus fields #517

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Dec 8, 2024

Description of changes

Replaces the current implementation, which (optionally) allows the RH dststatus fields to be written to individual files (per dst component, per mapindex) on the internal mesh representation. This requires the user to manipulate the written fields in order to visualize them on the model domain.

In this PR, if write_dststatus is true, a FBDdststatus is created for each destination component, containing all the mappings from n1 to n2 for that component and the dstatusfields are added to the component's FB. All the FBs are then written using med_io_write_FB using the cpl_scalars.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Fixes NOAA-EMC#127

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

B4B

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing

Built and tested in debug and release mode for UFS. All UFS configurations properly create the dststatus file when enabled.

* create a FB to hold the returned dststatus fields
* write all dststatus fields into one file via med_io_write_FB
in med.F90 if requested
* add mask to the FBdststatus
Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeniseWorthen I think this is very valuable addition to debug issues that we had previously. Thanks for improving it. Probably this needs to be tested with CESM to be sure it is working as expected before merging.

@uturuncoglu
Copy link
Collaborator

@jedwards4b @fischer-ncar I think we don't have any automated testing action yet. Right? As I know @jedwards4b was working on it but not sure it is functional or not to test this PR.

@uturuncoglu
Copy link
Collaborator

@DeniseWorthen BTW, did you see following error https://github.com/ESCOMP/CMEPS/actions/runs/12223728991/job/34095631540. It might be related with the PR or not. Not sure?

@jedwards4b
Copy link
Collaborator

@uturuncoglu The tests are failing because the externals are out of sync - I don't think that it's related to this PR.

@DeniseWorthen
Copy link
Collaborator Author

I did see that it failed on the check, but I wasn't sure about why.

Copy link
Collaborator

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedwards4b jedwards4b merged commit d8b0155 into ESCOMP:main Dec 9, 2024
0 of 2 checks passed
@jedwards4b jedwards4b deleted the feature/fbdstatus branch December 9, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve usability of dststatus fields
3 participants