Skip to content

Commit

Permalink
Merge pull request #444 from bedroge/pytorch_2.1.2_2023a
Browse files Browse the repository at this point in the history
{2023.06}[foss/2023a] PyTorch v2.1.2
  • Loading branch information
boegel authored Jan 26, 2024
2 parents d9cb30a + dc02a01 commit 6d80884
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,7 @@ easyconfigs:
- Rivet-3.1.9-gompi-2023a-HepMC3-3.2.6.eb:
options:
from-pr: 19679
- PyTorch-2.1.2-foss-2023a.eb:
options:
from-pr: 19573
- scikit-learn-1.3.1-gfbf-2023a.eb
10 changes: 10 additions & 0 deletions eb_hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,15 @@ def pre_test_hook_ignore_failing_tests_netCDF(self, *args, **kwargs):
if self.name == 'netCDF' and self.version == '4.9.2' and cpu_target == CPU_TARGET_NEOVERSE_V1:
self.cfg['testopts'] = "|| echo ignoring failing tests"

def pre_test_hook_increase_max_failed_tests_arm_PyTorch(self, *args, **kwargs):
"""
Pre-test hook for PyTorch: increase max failing tests for ARM for PyTorch 2.1.2
See https://github.com/EESSI/software-layer/pull/444#issuecomment-1890416171
"""
if self.name == 'PyTorch' and self.version == '2.1.2' and get_cpu_architecture() == AARCH64:
self.cfg['max_failed_tests'] = 10


def pre_single_extension_hook(ext, *args, **kwargs):
"""Main pre-extension: trigger custom functions based on software name."""
if ext.name in PRE_SINGLE_EXTENSION_HOOKS:
Expand Down Expand Up @@ -587,6 +596,7 @@ def inject_gpu_property(ec):
'FFTW.MPI': pre_test_hook_ignore_failing_tests_FFTWMPI,
'SciPy-bundle': pre_test_hook_ignore_failing_tests_SciPybundle,
'netCDF': pre_test_hook_ignore_failing_tests_netCDF,
'PyTorch': pre_test_hook_increase_max_failed_tests_arm_PyTorch,
}

PRE_SINGLE_EXTENSION_HOOKS = {
Expand Down
11 changes: 11 additions & 0 deletions eessi-2023.06-known-issues.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
- aarch64/generic:
- PyTorch-2.1.2-foss-2023a:
- issue: https://github.com/EESSI/software-layer/issues/461
- info: "8 failing tests (out of 209539) on aarch64/*"
- aarch64/neoverse_n1:
- PyTorch-2.1.2-foss-2023a:
- issue: https://github.com/EESSI/software-layer/issues/461
- info: "8 failing tests (out of 209539) on aarch64/*"
- aarch64/neoverse_v1:
- ESPResSo-4.2.1-foss-2023a:
- issue: https://github.com/EESSI/software-layer/issues/363
Expand All @@ -17,6 +25,9 @@
- OpenBLAS-0.3.21-GCC-12.2.0:
- issue: https://github.com/EESSI/software-layer/issues/314
- info: "Increased number of numerical errors in OpenBLAS test suite (344 vs max. 150 on x86_64/*)"
- PyTorch-2.1.2-foss-2023a:
- issue: https://github.com/EESSI/software-layer/issues/461
- info: "8 failing tests (out of 209539) on aarch64/*"
- SciPy-bundle-2023.02-gfbf-2022b:
- issue: https://github.com/EESSI/software-layer/issues/318
- info: "numpy built with -march=armv8.4-a instead of -mcpu=native (no SVE) + 2 failing tests (vs 50005 passed) in scipy test suite"
Expand Down

0 comments on commit 6d80884

Please sign in to comment.