Add neighbor list unit test #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
force-pushed
the
unittest_neighbor
branch
from
dcadc10 to
dd70f51
Compare
sslattery
approved these changes
Jul 17, 2020
| @@ -46,4 +50,7 @@ macro(CabanaMD_add_tests) | |||
| endforeach() | |||
| endmacro() | |||
|
|
|||
| CabanaMD_add_tests(MPI NAMES Integrator) | |||
| CabanaMD_add_tests(NAMES Integrator Neighbor) | |||
There was a problem hiding this comment.
Will you add the MPI case back here for tests that require multiple ranks?
There was a problem hiding this comment.
Yes, that should only be the Comm class
|
|
||
| //---------------------------------------------------------------------------// | ||
| template <class ListType, class PositionSlice> | ||
| void checkFullNeighborListPartialRange( const ListType &list, |
There was a problem hiding this comment.
I'm wondering if we can combine the full and partial test to reduce code here but I think this is OK for now as it is essentially what I implemented in Cabana
There was a problem hiding this comment.
Yeah, I should do that both here and in Cabana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are very similar to those in Cabana.
This also ensures that we don't test with more than one MPI rank (except for the future
Commtest) and updates unit_test file license years.One more towards #44